LIMS-1876: Fix URL parameters on fault report list #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfrn
reviewed
Oct 8, 2025
| _.each(frags, function(v, f) { | ||
| url = url.replace(new RegExp('\\/'+f+'\\/\\w+'), '') | ||
| if (this.ui[v].val() != 0) url += '/'+f+'/'+this.ui[v].val() | ||
| if (this.ui[v].val() && this.ui[v].val() != 0) url += '/'+f+'/'+this.ui[v].val() |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (this.ui[v].val() && this.ui[v].val() != 0) url += '/'+f+'/'+this.ui[v].val() | |
| if (!!this.ui[v].val()) url += '/'+f+'/'+this.ui[v].val() |
Suggested change
| if (this.ui[v].val() && this.ui[v].val() != 0) url += '/'+f+'/'+this.ui[v].val() | |
| if (this.ui[v].val()) url += '/'+f+'/'+this.ui[v].val() |
Is there any reason why we need the "!= 0"? As 0 is already falsy in JS
As an added measure of precaution, we can even cast the val to a bool with !! before evaluating (that means null, undefined, 0, false will all evaluate to false)
Collaborator
Author
There was a problem hiding this comment.
Turns out it was "0" not 0, so it was truthy. So I've removed the value="0" from the dropdowns, and changed the PHP to handle that. Also removed some weirdness with a misnamed beamline "i04 1" and an arg called "array" which I can't find anywhere.
gfrn
approved these changes
Oct 9, 2025
ndg63276
added a commit
that referenced
this pull request
Oct 22, 2025
* LIMS-1924: Fix update of container owner (#988) * LIMS-1923: Fix downstream accordion if files missing from disk (#987) * LIMS-1876: Fix URL parameters on fault report list (#979) * LIMS-1841: Link downstream jobs to their upstream counterpart (#985) * LIMS-1836: Improvements to reprocessing (#978)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1876
Summary:
When viewing fault reports, if you apply a filter, you get a URL like https://ispyb.diamond.ac.uk/faults/bl/i03/sys/null/com/null/sub/null, but refreshing that URL gives an error.
Changes:
To test: