-
Notifications
You must be signed in to change notification settings - Fork 3
BBA Changes #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBA Changes #31
Conversation
|
The Python 3.7 build is failing due to |
078fc8d to
6b5c153
Compare
72a082e to
4d716ed
Compare
MJGaughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're able to be more explicit about the cause of errors with other cothread applications, I would suggest adding that but otherwise this PR is good.
|
I don't think I can elaborate concisely on the issue with other cothread applications. Side note, I noticed that the fix for the issue in AT that was blocking us from making I04 the default ring mode got merged, so I've updated it and snuck it on the end of this pr. Also, for some reason, I don't have merge permissions for this repo or Pytac, but I do for dls-bba |
Changes made while attempting to get BBA to interface with the virtac.