Merged
Conversation
douglaswinter
force-pushed
the
dw/test_coverage
branch
2 times, most recently
from
887dac1 to
8c133d9
Compare
douglaswinter
requested review from
VictoriaBeilsten-Edmands and
noemifrisina
douglaswinter
force-pushed
the
dw/test_coverage
branch
from
8c133d9 to
05a9c6b
Compare
douglaswinter
force-pushed
the
dw/test_coverage
branch
from
05a9c6b to
7cfa924
Compare
EmsArnold
requested changes
Mar 11, 2026
Contributor
EmsArnold
left a comment
EmsArnold
left a comment
There was a problem hiding this comment.
One comment on potential additional documentation.
This highlights how poor our coverage is for ViSR and i15-1, further issues should be created to increase this coverage and/or review what should be covered.
Also downgrade vitest-conf/RTL to 15 for React 18.
Also remove build dependency for the coverage turbo job, from an earlier architecture.
douglaswinter
force-pushed
the
dw/test_coverage
branch
from
7cfa924 to
04dedde
Compare
Collaborator
Author
Yep. After this change goes in I'll add the CI job that checks coverage. The strategy will be to simply prevent coverage regression per app/package. We can later have more stringent requirements for shared packages particularly, so that app devs have confidence in using them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
v8 coverage provider installed in root as dev dependency
@atlas/vitest-conf includes all source code with some generic exclusions
@atlas/visr adds another exclusion; this is documented in @atlas/vitest-conf README
A GitHub workflow action will be pushed after this is merged