I15-1: Add read only PV fields#33
Conversation
EmsArnold
left a comment
There was a problem hiding this comment.
Looks good to me, just two comments, and it may be good to test on the beamline to ensure we're getting the PVs through if that hasn't been done yet.
Could: add a handler for mocking the new subscription, something like this should work:
import { http, HttpResponse, ws } from "msw";
...
const chat = ws.link("wss://pvws.diamond.ac.uk/pvws/pv");
export const handlers = [
...
chat.addEventListener("connection", () => {
console.log("WebSocket client connecting...");
}),
];Nit: when deployed locally, the Diamond logo is very small for me - but only for i15-1, and not for ViSR. I couldn't find any obvious reason for this.
Good spot, thanks. I'm afraid I completely forgot to do this, will add now! On the diamond logo, yeah took a look and I have the same. Only thing I can think of is that I had to update some dependencies in the i15-1 package, sci-react-ui among them I believe (which is where we're getting the theme from) - looking into it |
|
The annoying bit when adding the handler to msw is that the pv boxes now read not connected by default even when running on a dls workstation |
|
The logo was fixed by slightly refactoring the Navbar |
Uh oh!
There was an error while loading. Please reload this page.