Add @atlas/app-shell and use it in i15-1#47
Merged
Conversation
douglaswinter
force-pushed
the
dw/new_layout
branch
3 times, most recently
from
b26f62c to
964dbfe
Compare
douglaswinter
requested review from
EmsArnold and
noemifrisina
and removed request for
noemifrisina
Collaborator
Author
|
The colours will be a bit off until the new release of SciReact which includes the new theme. |
douglaswinter
force-pushed
the
dw/new_layout
branch
2 times, most recently
from
6597914 to
2dc3d45
Compare
EmsArnold
approved these changes
Jun 2, 2026
Contributor
EmsArnold
left a comment
EmsArnold
left a comment
There was a problem hiding this comment.
Looks good to me.
I think being able to see (at least) one particular view without logging in is still useful, we should consider the best mechanism for this in the future.
Package creates a React Router router object with common navigation and shell components i.e. appbar, side navigation, tabbed pages.
douglaswinter
force-pushed
the
dw/new_layout
branch
from
5fa262a to
5bee8d1
Compare
douglaswinter
force-pushed
the
dw/new_layout
branch
from
5bee8d1 to
a0ffc20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://jira.diamond.ac.uk/browse/I15_1-1622
Adds shell and navigation according to https://www.figma.com/proto/bWGBDTZ9e5Ui2tQqD67lHd/Waffle-I15-1-Mail-in-experiments?node-id=3261-18541