Skip to content

refactor: fix regal lint issues#306

Merged
ZohebShaikh merged 1 commit into
DiamondLightSource:mainfrom
ZohebShaikh:main
May 20, 2026
Merged

refactor: fix regal lint issues#306
ZohebShaikh merged 1 commit into
DiamondLightSource:mainfrom
ZohebShaikh:main

Conversation

@ZohebShaikh
Copy link
Copy Markdown
Collaborator

@ZohebShaikh ZohebShaikh commented May 18, 2026 •
edited
Loading

Fix regal lints :-

  • regal ignore:default-over-else
  • regal ignore:external-reference as we have a ignore at the root
  • regal ignore:boolean-assignment
  • Use underscore when variable not used internally
    example: access_proposal(subject, _) if admin.is_admin(subject)

@ZohebShaikh ZohebShaikh marked this pull request as ready for review May 18, 2026 11:29
@ZohebShaikh ZohebShaikh requested a review from a team May 18, 2026 11:32
Alexj9837
Alexj9837 reviewed May 20, 2026
View reviewed changes
Comment thread policy/diamond/policy/session/session_test.rego Outdated
@ZohebShaikh ZohebShaikh requested a review from Alexj9837 May 20, 2026 12:13
@ZohebShaikh ZohebShaikh merged commit 616f490 into DiamondLightSource:main May 20, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpoliaw tpoliaw tpoliaw approved these changes

@Alexj9837 Alexj9837 Awaiting requested review from Alexj9837

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZohebShaikh @tpoliaw @Alexj9837