Skip to content

Improve code coverage#102

Merged
callumforrester merged 13 commits intomainfrom
fix-coverage
Mar 8, 2023
Merged

Improve code coverage#102
callumforrester merged 13 commits intomainfrom
fix-coverage

Conversation

@callumforrester
Copy link
Copy Markdown
Contributor

@callumforrester callumforrester commented Mar 8, 2023

Changes:

  • Drop codecov requirement from 85% to 70%, can be revised upward when design is more settled
  • Ignore startup directory when running codecov
  • Remove ... from abstract methods
  • Remove context manager from message template as it was unused
  • Cover message listener decorator with test
  • Remove unused methods
  • Test topics
  • Test event streams

@callumforrester callumforrester added the enhancement New feature or request label Mar 8, 2023
@callumforrester callumforrester added this to the Production Readiness milestone Mar 8, 2023
@callumforrester callumforrester self-assigned this Mar 8, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2023

Codecov Report

Merging #102 (68d8720) into main (8e95744) will increase coverage by 12.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #102       +/-   ##
===========================================
+ Coverage   60.10%   72.38%   +12.28%     
===========================================
  Files          39       35        -4     
  Lines        1148      967      -181     
===========================================
+ Hits          690      700       +10     
+ Misses        458      267      -191     
Impacted Files Coverage Δ
src/blueapi/core/event.py 100.00% <ø> (+37.50%) ⬆️
src/blueapi/messaging/base.py 100.00% <ø> (+30.18%) ⬆️
src/blueapi/messaging/context.py 100.00% <ø> (+12.50%) ⬆️
src/blueapi/worker/task.py 69.76% <ø> (+1.58%) ⬆️
src/blueapi/worker/worker.py 100.00% <ø> (+20.83%) ⬆️
src/blueapi/startup/simmotor.py
src/blueapi/startup/adsim.py
src/blueapi/startup/bl45p.py
src/blueapi/startup/example.py
src/blueapi/messaging/stomptemplate.py 92.10% <0.00%> (+0.87%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@callumforrester callumforrester merged commit 79b0477 into main Mar 8, 2023
@callumforrester callumforrester deleted the fix-coverage branch March 8, 2023 13:16
keithralphs pushed a commit that referenced this pull request Apr 28, 2023

Changes:

    Drop codecov requirement from 85% to 70%, can be revised upward when design is more settled
    Ignore startup directory when running codecov
    Remove ... from abstract methods
    Remove context manager from message template as it was unused
    Cover message listener decorator with test
    Remove unused methods
    Test topics
    Test event streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant