fix: Pin event-model to same version as dodal's pin#1064
Merged
DiamondJoseph merged 2 commits intomainfrom Jun 16, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 41 41
Lines 2506 2506
=======================================
Hits 2375 2375
Misses 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
olliesilvester
force-pushed
the
pin_event_model
branch
from
6d03d67 to
f4a113f
Compare
DiamondJoseph
approved these changes
Jun 16, 2025
tpoliaw
reviewed
Jun 16, 2025
| "dls-dodal>=1.46.0", | ||
| "super-state-machine", # https://github.com/DiamondLightSource/blueapi/issues/553 | ||
| "GitPython", | ||
| "event-model==1.23", # https://github.com/DiamondLightSource/blueapi/issues/684 |
Contributor
There was a problem hiding this comment.
Does this version work with whatever caused the version to be pinned to start with? I wasn't sure how the linked issue was related.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlueAPI and dodal currently pin different versions of
event-model, breaking any new deployments