feat: Add logout redirect#1166
Merged
ZohebShaikh merged 14 commits intomainfrom Aug 22, 2025
Merged
Conversation
ZohebShaikh
force-pushed
the
add-logout-redirect
branch
from
23f8ae2 to
7e2f1e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
+ Coverage 94.52% 94.54% +0.01%
==========================================
Files 41 41
Lines 2557 2565 +8
==========================================
+ Hits 2417 2425 +8
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
reviewed
Aug 15, 2025
Contributor
tpoliaw
left a comment
tpoliaw
left a comment
There was a problem hiding this comment.
Initial thoughts - I don't really know how the auth redirect stuff is intended to work so may not be relevant.
DiamondJoseph
suggested changes
Aug 15, 2025
Contributor
DiamondJoseph
left a comment
DiamondJoseph
left a comment
There was a problem hiding this comment.
Requesting some low hanging fruit while I grapple with the test
ZohebShaikh
force-pushed
the
add-logout-redirect
branch
from
ccb0c34 to
7314de8
Compare
ZohebShaikh
force-pushed
the
add-logout-redirect
branch
from
7314de8 to
76fdf18
Compare
DiamondJoseph
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we can logout by going to this https://p46-blueapi.diamond.ac.uk/oauth2/sign_out?rd=https%3A%2F%2Fauthn.diamond.ac.uk%2Frealms%2Fmaster%2Fprotocol%2Fopenid-connect%2Flogout. It will be much simpler to logout by going to https://p46-blueapi.diamond.ac.uk/logout. This is when we have oauth2-proxy enabled for blueapi docs page