fix: Fix bluesky dependency version requirements of tiled and dodal#1226
Merged
DiamondJoseph merged 2 commits intomainfrom Oct 6, 2025
Merged
fix: Fix bluesky dependency version requirements of tiled and dodal#1226DiamondJoseph merged 2 commits intomainfrom
DiamondJoseph merged 2 commits intomainfrom
Conversation
DiamondJoseph
force-pushed
the
fix_tiled_import
branch
from
4b7d289 to
dd60c9e
Compare
DiamondJoseph
changed the title
DiamondJoseph
force-pushed
the
fix_tiled_import
branch
from
dd60c9e to
4e20ac2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 41 41
Lines 2595 2595
=======================================
Hits 2456 2456
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
force-pushed
the
fix_tiled_import
branch
2 times, most recently
from
1b22649 to
d54d77c
Compare
DiamondJoseph
force-pushed
the
fix_tiled_import
branch
from
d54d77c to
0edb920
Compare
Contributor
|
It doesn't look like this change has anything to do with tiled? |
| coverage==7.10.7 | ||
| cryptography==46.0.2 | ||
| cycler==0.12.1 | ||
| daq-config-server==1.0.0rc2 |
Contributor
There was a problem hiding this comment.
Eee, wonder what pulled this in
Contributor
Author
There was a problem hiding this comment.
Latest version of dodal I expect
callumforrester
approved these changes
Oct 6, 2025
Contributor
Author
See ticket #1225 tiled>=0.1.0 requires to function but not explicitly bluesky>=1.14.4 So we needed dodal>=1.60.0 which is compatible with bluesky>=1.14.5 |
DiamondJoseph
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fxes #1225