Skip to content

depr: Deprecate DodalSource and DeviceSource#1362

Merged
tpoliaw merged 2 commits intomainfrom
deprecate-dodal-source
Jan 30, 2026
Merged

depr: Deprecate DodalSource and DeviceSource#1362
tpoliaw merged 2 commits intomainfrom
deprecate-dodal-source

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Jan 29, 2026

Just logs a warning when either is used. Is there a better way of marking things deprecated? warnings.deprecated seems useful but is 3.13+ only.

@tpoliaw tpoliaw requested a review from a team as a code owner January 29, 2026 14:54
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.04%. Comparing base (2f6f13a) to head (b7f682a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1362   +/-   ##
=======================================
  Coverage   95.03%   95.04%           
=======================================
  Files          43       43           
  Lines        2781     2783    +2     
=======================================
+ Hits         2643     2645    +2     
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw changed the title Deprecate DodalSource and DeviceSource depr: Deprecate DodalSource and DeviceSource Jan 30, 2026
@tpoliaw tpoliaw force-pushed the deprecate-dodal-source branch from c8f7b2f to 6efb6ba Compare January 30, 2026 11:04
@tpoliaw tpoliaw merged commit 28cbea2 into main Jan 30, 2026
18 checks passed
@tpoliaw tpoliaw deleted the deprecate-dodal-source branch January 30, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants