Skip to content

fix: Remove duplicate mark_task_as_started listener#1435

Merged
tpoliaw merged 1 commit intomainfrom
task-submit-subscribers
Apr 22, 2026
Merged

fix: Remove duplicate mark_task_as_started listener#1435
tpoliaw merged 1 commit intomainfrom
task-submit-subscribers

Conversation

@tpoliaw
Copy link
Copy Markdown
Contributor

@tpoliaw tpoliaw commented Mar 6, 2026

Only one of the listeners was unsubscribed so they would pile up in the
WorkerEvent publisher.

@tpoliaw tpoliaw requested a review from a team as a code owner March 6, 2026 13:05
@tpoliaw tpoliaw force-pushed the task-submit-subscribers branch from 48fcd68 to b5d949c Compare March 6, 2026 13:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.25%. Comparing base (79cae0b) to head (0fa876d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
- Coverage   95.25%   95.25%   -0.01%     
==========================================
  Files          43       43              
  Lines        3164     3163       -1     
==========================================
- Hits         3014     3013       -1     
  Misses        150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw force-pushed the task-submit-subscribers branch from b5d949c to e36cfe8 Compare April 8, 2026 13:34
@tpoliaw tpoliaw requested a review from dan-fernandes April 8, 2026 13:49
@NeilSmithDLS NeilSmithDLS self-requested a review April 13, 2026 10:57
@tpoliaw tpoliaw force-pushed the task-submit-subscribers branch from e36cfe8 to e326f07 Compare April 13, 2026 11:03
Only one of the listeners was unsubscribed so they would pile up in the
WorkerEvent publisher.
@tpoliaw tpoliaw force-pushed the task-submit-subscribers branch from e326f07 to 0fa876d Compare April 22, 2026 13:39
@tpoliaw tpoliaw merged commit 107d54e into main Apr 22, 2026
17 checks passed
@tpoliaw tpoliaw deleted the task-submit-subscribers branch April 22, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants