Skip to content

Developer tutorials and how-tos#151

Merged
callumforrester merged 2 commits intomainfrom
dev-tutorials
Apr 28, 2023
Merged

Developer tutorials and how-tos#151
callumforrester merged 2 commits intomainfrom
dev-tutorials

Conversation

@callumforrester
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2023

Codecov Report

Merging #151 (9e44f0f) into main (35ee75a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          37       37           
  Lines        1050     1050           
=======================================
  Hits          782      782           
  Misses        268      268           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seamed to work for me. Perhaps separate the starting worker in cli and vs-code to separate bits for clarity:

Start worker from cli:
 --blah

Or start worker from vscode:
--blah

@abbiemery
Copy link
Copy Markdown
Contributor

@callumforrester have you got plans for a doc somewhere to explain how to use the other cli options? Running & sending etc

@callumforrester
Copy link
Copy Markdown
Contributor Author

It currently uses tabs to separate them, does that seem confusing?
https://diamondlightsource.github.io/blueapi/dev-tutorials/developer/tutorials/dev-run.html

@abbiemery
Copy link
Copy Markdown
Contributor

It currently uses tabs to separate them, does that seem confusing? https://diamondlightsource.github.io/blueapi/dev-tutorials/developer/tutorials/dev-run.html

Not at all thats fine, I was reading the diff so was just guessing at rendering. My bad!. Looks good then :)

@callumforrester callumforrester marked this pull request as ready for review April 28, 2023 07:31
@callumforrester callumforrester merged commit d387aa7 into main Apr 28, 2023
@callumforrester callumforrester deleted the dev-tutorials branch April 28, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants