Create documentation page about events #152
Merged
callumforrester merged 4 commits intomainfrom May 11, 2023
Merged
Conversation
Contributor
callumforrester
commented
Apr 25, 2023
- Add page about events to developer documentation
- Explain why we need to add new events on top of the event model
- Explain the use of correlation IDs
Contributor
Author
|
Still to do: make API reference and point to that |
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 83.07% 74.47% -8.61%
==========================================
Files 40 37 -3
Lines 1111 1050 -61
==========================================
- Hits 923 782 -141
- Misses 188 268 +80 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DiamondJoseph
suggested changes
May 4, 2023
Contributor
DiamondJoseph
left a comment
There was a problem hiding this comment.
nit, otherwise LGTM
Contributor
|
Presumably going to need an update for emitting state events on same topic? |
58ecb40 to
6256cea
Compare
Contributor
Do that as part of addressing #176 |
DiamondJoseph
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.