Skip to content

Asyncapi#153

Merged
keithralphs merged 9 commits intomainfrom
asyncapi
Apr 28, 2023
Merged

Asyncapi#153
keithralphs merged 9 commits intomainfrom
asyncapi

Conversation

@keithralphs
Copy link
Copy Markdown
Contributor

Initial version for review, please see if it looks sensible

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2023

Codecov Report

Merging #153 (aa2abab) into main (d387aa7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          37       37           
  Lines        1050     1050           
=======================================
  Hits          782      782           
  Misses        268      268           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches were a bit mangled so probably needs a rebase

Comment thread src/blueapi/service/app.py Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
Comment thread asyncapi.yaml Outdated
@keithralphs keithralphs dismissed stale reviews from callumforrester and DiamondJoseph April 27, 2023 14:36

Already been reverted

Copy link
Copy Markdown
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLGTM

@keithralphs keithralphs merged commit 58317f4 into main Apr 28, 2023
@keithralphs keithralphs deleted the asyncapi branch May 18, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants