Skip to content

Remove support for Python 3.8#159

Merged
DiamondJoseph merged 1 commit intoDiamondLightSource:mainfrom
tpoliaw:min_version
May 2, 2023
Merged

Remove support for Python 3.8#159
DiamondJoseph merged 1 commit intoDiamondLightSource:mainfrom
tpoliaw:min_version

Conversation

@tpoliaw
Copy link
Copy Markdown
Contributor

@tpoliaw tpoliaw commented May 2, 2023

Fixes: #122
May also fix #114

Copy link
Copy Markdown
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes #114

@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2023

Codecov Report

Merging #159 (57df25d) into main (58317f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          37       37           
  Lines        1050     1050           
=======================================
  Hits          782      782           
  Misses        268      268           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DiamondJoseph DiamondJoseph merged commit bcfabb7 into DiamondLightSource:main May 2, 2023
@tpoliaw tpoliaw deleted the min_version branch May 2, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.8 Update github action matrix to test -e on/off on same python version

2 participants