Use random UUID for StatusView names#162
Merged
DiamondJoseph merged 1 commit intomainfrom May 4, 2023
Merged
Conversation
Contributor
Author
|
Fixes #161 |
This generates names which are more clearly distinct when looking through logs.
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 74.47% 74.47%
=======================================
Files 37 37
Lines 1050 1050
=======================================
Hits 782 782
Misses 268 268
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
DiamondJoseph
left a comment
DiamondJoseph
left a comment
There was a problem hiding this comment.
uuid1 is more guaranteed to be unique, but uuid4 is much more obvious when two uuids aren't the same when reading the logs. I think the odds of collision over the lifetime of the service is so low that this is worth using as the standard generator but I leave the final decision to @callumforrester
callumforrester
approved these changes
May 3, 2023
Contributor
callumforrester
left a comment
callumforrester
left a comment
There was a problem hiding this comment.
Happy to do so, I'm also not married to uuids, we can use an atomic counter or something if that helps.
DiamondJoseph
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generates names which are more clearly distinct when looking through logs.