Conversation
|
The CI should be fixed if you rebase on |
callumforrester
left a comment
There was a problem hiding this comment.
Looking good! Only a few small items.
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 87.39% 87.36% -0.04%
==========================================
Files 40 40
Lines 1079 1092 +13
==========================================
+ Hits 943 954 +11
- Misses 136 138 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@callumforrester I made the changes you requested. I also added a better test case for the context which will cause the CI to fail untill the |
946e188 to
adac983
Compare
|
@callumforrester Done the last things you pointed out and rebased. The tests will still fail until the dodal updates are merged. I'm just waiting on a review for that. |
callumforrester
left a comment
There was a problem hiding this comment.
Provisionally approving pending dodal PR merge. Only minor comments now. Some docstrings on new classes/methods would also be good if you have time.
Fixes #121 .
Needs to have this dodal pr to be merged to work, otherwise the devices that use other devices in the example start up will not work.
It also fails on the 3.8 tests, so maybe we remove the support for that first.