fix json parameterization bug#186
Merged
rosesyrett merged 2 commits intoDiamondLightSource:mainfrom May 12, 2023
Merged
Conversation
…can actually be run
DiamondJoseph
approved these changes
May 12, 2023
Contributor
Author
|
Going to follow this up with a couple of PRs; one to deal with the fact the tests fail if the server is running, and the other dealing with correlation IDs #177 which would involve changing the cli command so it doesn't automatically return on submission and can return error codes from the worker. |
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 41 41
Lines 1091 1091
=======================================
Hits 955 955
Misses 136 136
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed a bug in the json parametarization for running plans, so plans can actually be run