Made tests work with server running#189
Merged
rosesyrett merged 3 commits intoDiamondLightSource:mainfrom May 12, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 87.53% 87.62% +0.09%
==========================================
Files 41 41
Lines 1091 1091
==========================================
+ Hits 955 956 +1
+ Misses 136 135 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tpoliaw
reviewed
May 12, 2023
DiamondJoseph
approved these changes
May 12, 2023
Contributor
Author
|
solves #187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a simple bug; one of the tests in test_cli.py assumed the server isn't running, which means if it is, it fails.
I've mocked out the api call this makes now. So now the tests work with the server running.