Make run plan parameters an argument#207
Merged
tpoliaw merged 1 commit intoDiamondLightSource:mainfrom May 18, 2023
tpoliaw:param_arg
Merged
Make run plan parameters an argument#207tpoliaw merged 1 commit intoDiamondLightSource:mainfrom tpoliaw:param_arg
tpoliaw merged 1 commit intoDiamondLightSource:mainfrom
tpoliaw:param_arg
Conversation
Instead of an option that is required in every call. If no parameters are passed, default to empty dict.
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 87.50% 87.51% +0.01%
==========================================
Files 41 41
Lines 1120 1121 +1
==========================================
+ Hits 980 981 +1
Misses 140 140
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
joeshannon
approved these changes
May 17, 2023
Contributor
joeshannon
left a comment
joeshannon
left a comment
There was a problem hiding this comment.
It looks like a sensible change to me.
Do we want to check if others agree?
callumforrester
approved these changes
May 17, 2023
Contributor
|
Definitely nicer, cheers |
Merged
keithralphs
pushed a commit
that referenced
this pull request
Aug 29, 2023
Since #207 the `-p` is not needed for the CLI, this removes it in the docs. Co-authored-by: DiamondJoseph <53935796+DiamondJoseph@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of an option that is required in every call. If no parameters are passed,
default to empty dict.