Allow pausing and resuming of the worker#229
Merged
DiamondJoseph merged 2 commits intomainfrom May 25, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 89.06% 88.57% -0.50%
==========================================
Files 41 41
Lines 1271 1339 +68
==========================================
+ Hits 1132 1186 +54
- Misses 139 153 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tpoliaw
reviewed
May 24, 2023
Contributor
tpoliaw
left a comment
tpoliaw
left a comment
There was a problem hiding this comment.
It doesn't feel very RESTy to use query parameters for the payload of a PUT request. Should it be a {"status": "pause", "defer": true} body instead?
DiamondJoseph
changed the title
keithralphs
suggested changes
May 25, 2023
DiamondJoseph
commented
May 25, 2023
| '404': | ||
| description: Not Found | ||
| item: not found | ||
| detail: item not found |
Contributor
Author
There was a problem hiding this comment.
This is the same as the 404 message returned when a KeyError or ValueError is thrown. Using it as a standard will probably save us time later on.
joeshannon
reviewed
May 25, 2023
DiamondJoseph
commented
May 25, 2023
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| @pytest.fixture |
Contributor
Author
There was a problem hiding this comment.
scope="session" left state hanging around, its inclusion was due to a misunderstanding of fixtures.
keithralphs
approved these changes
May 25, 2023
rosesyrett
approved these changes
May 25, 2023
Contributor
rosesyrett
left a comment
rosesyrett
left a comment
There was a problem hiding this comment.
just a few questions/comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.