Skip to content

Test cli#230

Merged
DiamondJoseph merged 1 commit intomainfrom
test-cli
May 26, 2023
Merged

Test cli#230
DiamondJoseph merged 1 commit intomainfrom
test-cli

Conversation

@DiamondJoseph
Copy link
Copy Markdown
Contributor

@DiamondJoseph DiamondJoseph commented May 24, 2023

Part of #198

For discussion: What should putting a task with invalid parameters, or putting a task that does not exist do?

Dependent on #202

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2023

Codecov Report

Merging #230 (c0b9874) into main (ea63806) will increase coverage by 1.25%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   88.57%   89.82%   +1.25%     
==========================================
  Files          41       41              
  Lines        1339     1347       +8     
==========================================
+ Hits         1186     1210      +24     
+ Misses        153      137      -16     
Impacted Files Coverage Δ
src/blueapi/service/main.py 92.59% <94.44%> (+10.31%) ⬆️
src/blueapi/utils/base_model.py 100.00% <100.00%> (ø)
src/blueapi/worker/reworker.py 94.95% <100.00%> (+0.04%) ⬆️
src/blueapi/worker/task.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread src/blueapi/worker/reworker.py Outdated
Comment thread src/blueapi/service/main.py Outdated
@DiamondJoseph DiamondJoseph force-pushed the test-cli branch 5 times, most recently from 48becb9 to 29089ff Compare May 26, 2023 14:12
Use status enum for ease of read

Do not cache handler and test client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants