Skip to content

Include errors in current task and synchronise on begin_task#234

Merged
callumforrester merged 4 commits intomainfrom
errors-on-task
May 25, 2023
Merged

Include errors in current task and synchronise on begin_task#234
callumforrester merged 4 commits intomainfrom
errors-on-task

Conversation

@callumforrester
Copy link
Copy Markdown
Contributor

Changes:

  • Replace the is_error field on TrackableTask with errors, a list of strings
  • Include all errors generated while a task is active in its errors
  • Synchronise begin_task so it blocks until the runner thread has set the active task, allows:
worker.begin_task(my_id)
active = worker.get_active_task()
assert active.task_id == my_id

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2023

Codecov Report

Merging #234 (194a78d) into main (d31287f) will decrease coverage by 0.23%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   89.90%   89.68%   -0.23%     
==========================================
  Files          41       41              
  Lines        1248     1260      +12     
==========================================
+ Hits         1122     1130       +8     
- Misses        126      130       +4     
Impacted Files Coverage Δ
src/blueapi/worker/reworker.py 94.76% <91.66%> (-1.73%) ⬇️
src/blueapi/worker/worker.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@callumforrester callumforrester merged commit e015d6c into main May 25, 2023
@callumforrester callumforrester deleted the errors-on-task branch May 25, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants