Skip to content

Use task response#93

Merged
callumforrester merged 2 commits intomainfrom
useTaskResponse
Feb 9, 2023
Merged

Use task response#93
callumforrester merged 2 commits intomainfrom
useTaskResponse

Conversation

@callumforrester
Copy link
Copy Markdown
Contributor

The TaskResponse model was unused, a raw string was being sent as a response

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2023

Codecov Report

Merging #93 (bb86795) into main (c6ee80a) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   59.03%   58.91%   -0.12%     
==========================================
  Files          38       38              
  Lines        1052     1054       +2     
==========================================
  Hits          621      621              
- Misses        431      433       +2     
Impacted Files Coverage Δ
src/blueapi/cli/amq.py 46.42% <0.00%> (-1.72%) ⬇️
src/blueapi/service/app.py 41.66% <0.00%> (-0.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@callumforrester callumforrester merged commit 842aa86 into main Feb 9, 2023
@callumforrester callumforrester deleted the useTaskResponse branch February 9, 2023 11:31
keithralphs pushed a commit that referenced this pull request Apr 28, 2023
* Use task response model to acknowledge a task

* Update CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant