Update valgrind.h to new version + ignore warning #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We throw away the return of a macro, which on Mac builds triggers a warning (which we promote to an error due to settings in setup.py). Note this error does not happen on other platforms due to different versions of the macro used per-platform.
AlexanderWells-diamond
force-pushed
the
fix_macos_build
branch
from
46019f9 to
6bc475e
Compare
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 59.94% 59.84% -0.10%
==========================================
Files 16 16
Lines 2072 2072
==========================================
- Hits 1242 1240 -2
- Misses 830 832 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlexanderWells-diamond
force-pushed
the
fix_macos_build
branch
from
6bc475e to
af8405a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We throw away the return of a macro, which on Mac builds triggers a warning (which we promote to an error due to settings in setup.py). Note this error does not happen on other platforms due to different versions of the macro used per-platform.