Fix Symbol relative paths #134
Conversation
GregJHarris
left a comment
GregJHarris
left a comment
There was a problem hiding this comment.
I've added a couple of minor comments.
src/ui/widgets/Image/image.tsx
Outdated
| flipHorizontal ? -1 : 1 | ||
| }) scaleY(${flipVertical ? -1 : 1})`, | ||
| objectFit: stretchToFit ? "fill" : "none", | ||
| objectFit: ratio ? "contain" : stretchToFit ? "fill" : "contain", |
There was a problem hiding this comment.
Might be worth simplifying this to something like:
objectFit: ratio || !stretchToFit ? "contain" : "fill",
| } | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
A general comment: Throughout this function we are mutating the object widgetDescription. Typescript prefers immutable objects. If I were to write this function opiPatchPaths from scratch I would have it return a new instance of WidgetDescription. Which I think would make its operation more transparent.
There was a problem hiding this comment.
Thanks @GregJHarris, I agree it will make it more transparent. I hadn't properly noticed it was just mutating the existing widgetDescription.
This fixes the issue of Symbols not displaying for relative paths. I've also corrected some of the sizing of the symbols to match Phoebus.