-
Notifications
You must be signed in to change notification settings - Fork 1
Update symbol widget #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c007e54 to
f7ed9e1
Compare
Collaborator
Collaborator
Author
|
I hadn't noticed those issues, thank for pointing them out! I'll have a look into them, and if they seem to be a separate issue that would be difficult to fix, I can do it as a separate PR. |
rjwills28
requested changes
Dec 9, 2024
rjwills28
approved these changes
Dec 10, 2024
Collaborator
rjwills28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great - thanks for identifying that that was the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Current implementation of the Symbol widget in cs-web-lib was based off the MultiStateMonitor widget in CSStudio. The Phoebus Symbol widget implementation was not applied.
I've now updated this widget to behave like the Phoebus widget. Tests and snapshots have also been updated. We check whether the symbol should behave like MultiStateMonitor or Symbol, so both opi and bob file behaviours are preserved.