Export some hooks and necessary datatypes #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abigailalexander
approved these changes
Nov 29, 2024
Collaborator
abigailalexander
left a comment
abigailalexander
left a comment
There was a problem hiding this comment.
Looks all good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
I think this is enough to get us going, thanks for being open to these changes @abigailalexander !
We might want to add a few more later but I'm erring on the side of caution for the moment. We are actually kind of interested in splitting out the PVWS communication + React hooks into a separate library (which we would be willing to help maintain!) because it could be reused in a lot of projects which don't correspond to CS-Studio stuff, but that is a discussion to have with @DominicOram next year.