Skip to content

Fix findDOMNode deprecation warning in slideshow widget #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix findDOMNode deprecation warning in slideshow widget #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/ui/widgets/Slideshow/slideshow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,15 @@ export const SwitchableWidget = (props: {
index: number;
children: [ReactElement];
transition: { readonly [key: string]: string };
nodeRef: React.Ref<HTMLDivElement>;
}): JSX.Element => {
// react-transition-group internally uses findDOMNode which
// is deprecated. Fix by passing nodeRef which points to the
// transitioning child.
return (
<SwitchTransition mode="out-in">
<CSSTransition
nodeRef={props.nodeRef}
classNames={props.transition}
key={props.index}
timeout={250}
Expand Down Expand Up @@ -69,6 +74,7 @@ export const SlideshowComponent = (
const [transition, setTransition] = useState(slideRightTransition);

log.debug(`Slideshow Index: ${childIndex}`);
const nodeRef = React.useRef<HTMLDivElement>(null);

return (
<div
Expand Down Expand Up @@ -104,6 +110,7 @@ export const SlideshowComponent = (
◀
</button>
<div
ref={nodeRef}
style={{
position: "relative",
width: "80%",
Expand All @@ -114,7 +121,11 @@ export const SlideshowComponent = (
overflow: props.overflow ?? ""
}}
>
<SwitchableWidget index={childIndex} transition={transition}>
<SwitchableWidget
index={childIndex}
transition={transition}
nodeRef={nodeRef}
>
{props.children as [ReactElement]}
</SwitchableWidget>
</div>
Expand Down
Loading