Update font sizing #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following changes to the conversion factor.
rjwills28
approved these changes
Jan 31, 2025
Collaborator
rjwills28
left a comment
rjwills28
left a comment
There was a problem hiding this comment.
Thanks for these changes. I tested against cs-web-proto which has a test widget page and noticed a few other sizing issues so I've just fixed the default font sizes for a few additional widgets.
Hopefully we've caught everything - otherwise we'll just have to fix them when we come across them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, font sizing in cs-web-lib used the 62.5% font-size trick for font-sizing, which requires client applications to set the root font size to 62.5% for fonts to appear the correct size. This isn't very transparent and there seem to be mixed reviews on using it. It causes issues when trying to use cs-web-lib in a client application that uses e.g. MUI components alongside bob screens.
I have swapped the font back to calculating REM from pixels by using the browser default font size of 16px and added a comment for context. This won't scale correctly if a browser user manually adjusts the browser default font size, but the .bob screens don't scale correctly anyway.