Modify and export addPage widget actions #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented these changes to come up with a solution to issues I faced when creating a client application that opens and displays files.
Suggested changes:
To test these changes, you can clone https://github.com/DiamondLightSource/daedalus and use a local build of cs-web-lib with these changes. You should be able to see with these changes how .bob files can be opened through the .bob file screens themselves, but also through a menubar and breadcrumbs trail, with the URL changing when a new file is opened.
I think overall the structure of adding tabs/pages needs an overhaul, but that would be better done at a separate time once we're sure what approach we want to take with it. For now, these changes expand the use of cs-web-lib while not changing the behaviour.