Replaced Checkbox with MUI Checkbox #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abigailalexander
requested changes
Mar 31, 2025
Collaborator
abigailalexander
left a comment
abigailalexander
left a comment
There was a problem hiding this comment.
Looks good overall, I only had a few small comments that are quite similar to those on the ActionButton PR.
I did notice that the Checkbox doesn't seem to be located correctly in the page, it's setting some padding that makes it shift down and to the right of where it should be compared to Phoebus (see images - left is the size and position of the widget as defined in Phoebus, right shows how the padding is forcing the entire component including the label to be shifted)
 |
 |
|---|
Collaborator
abigailalexander
left a comment
abigailalexander
left a comment
There was a problem hiding this comment.
Thanks for fixing those other items. Just the issue with the padding/sizing of the checkbox that I mentioned to you remaining. From what I saw when I looked into it:
- Unneeded padding on the MUI Checkbox component itself
- Unnecessary right-side margin on the MUI Form Control element
- Some sort of size restriction that doesn't allow the Checkbox Icon to go small enough. It seems like it might be one of the MUI internal components that needs adjusting e.g.
MuiCheckbox-root
abigailalexander
approved these changes
Apr 9, 2025
NatLeung96
added a commit
that referenced
this pull request
Apr 10, 2025
* Replaced Checkbox with MUI Checkbox * Removed ThemeProvider and added additional styling to FormControlLabel * Moved static styling to styled API. Not-allowed cursor when widget is disabled. Added font styling. * Removed padding * Removed padding and fixed alignments
NatLeung96
added a commit
that referenced
this pull request
Apr 23, 2025
* Added styling * Setup placeholder until option is clicked * 86 replace boolean button with mui button (#92) * Replaced base html button with MUI Button * Implemented disabled features and tidied up style parameters * Moved static styling to styled API * Commented out Button styling from tests * Update tests and snapshots * 90 replace label with mui typography (#93) * Replaced div with MUI Typography * Added styling props to Typography * Updated the tests for label * Updated symbols test * Removed ThemeProvider and tidied styling parameters * Updated tokens and fixed rotation * Updated snapshots * Removed redundant css file * Moved static styling to styled API * Updated tests and snapshots * Set display to flex * Updated snapshots * Updated snapshot * Replaced Checkbox with MUI Checkbox (#89) * Replaced Checkbox with MUI Checkbox * Removed ThemeProvider and added additional styling to FormControlLabel * Moved static styling to styled API. Not-allowed cursor when widget is disabled. Added font styling. * Removed padding * Removed padding and fixed alignments * Tidied nested for-loop * Tidied up styling and prop definitions * Added DType proptypes * Updated snapshots and tests * Changed menuButton logics and added items as potential list of options * Added useEffect to prevent re-render errors * Updated tests and snapshot * 87 replace choice button with mui button group (#98) * Replaced base react button group with MUI ToggleButtonGroup * Commented out expect statements checking the styling * Removed ThemeProvider * Moved static styling to styled API * Updated tests * Removed redundant height and width for ButtonGroup * Set opacity to 0.6 for hover and selected-hover * Added borders to buttons and fixed text wrapping * Updated snapshots * Deleted redundant CSS file * Removed CSS import * Changed button height/width and hover opacity * Updated snapshots * 95 replace progress bar with mui progress bar (#100) * Replaced divs with LinearProgress * Added width and height to parser * Implemented vertical orientation * Implements default width and height if not provided * Fixed width and height checking * Fixed label and removed redundant css file * Moved default width and height declarations to function head * Removed redundant height and width from bob parser * Corrected percentage calculation * Added transparency option * Added check for out of range values * 91 replace input with mui textfield (#99) * Replaced base input with MUI TextField * Updated theme tokens and changed border colours * Move static styling to styled API * Added alignment props to parser * Handle alignment props * Updated test and created snapshot * Removed redundant input component files * Removed redundant reference to component file * Removed redundant horizontalAlignment and verticalAlignment props from parser * Added textAlignV as ChoicePropOpt and removed unnecessary switch statements * Added if-else for vertical alignment * Changed default background to teal (#80FFFF) * Removed redundant border parsing * Changed color of hover and focussed borders to blue * Added custom border * Added multiLine to parser * Changed default blue border colour * TextField displays existing PV value if available * Reformatted prop type declaration and disabled cursor when disabled * Updated tests, snapshots, and type definitions * Updated slidecontrol test * Updated input snapshot * Corrected writePV function call * Removed redundant CSS file * Added blur on Enter * Removed comment * Got border thicknesses to change on hover and focus * Changed border width values for hover and focussed * Updated snapshot * Reorganised widgetprop definitions and updated test * Added useEffect to set initial text value when PV connection is established * Updated pvName variable in slideControl * Updated slideControl test * Added multiline functionality * Removed unnecessary DTypeProp types * Removed unnecessary props from MenuButtonComponentProps * Removed unnecessary import of DType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.