Make specific lookup table models #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Villtord
requested changes
Jan 8, 2026
Contributor
Villtord
left a comment
Villtord
left a comment
There was a problem hiding this comment.
Looks fine (as long as the column names of those dedicated lookuptables are standard), just a few suggestions
src/daq_config_server/models/converters/lookup_tables/_models.py
Outdated
Show resolved
Hide resolved
src/daq_config_server/models/converters/lookup_tables/_models.py
Outdated
Show resolved
Hide resolved
src/daq_config_server/models/converters/lookup_tables/_converters.py
Outdated
Show resolved
Hide resolved
jacob720
force-pushed
the
make_specific_luts
branch
from
597e6b1 to
c872516
Compare
jacob720
force-pushed
the
make_specific_luts
branch
from
c872516 to
63b0794
Compare
Villtord
reviewed
Jan 8, 2026
Villtord
approved these changes
Jan 8, 2026
Contributor
Villtord
left a comment
Villtord
left a comment
There was a problem hiding this comment.
All looks good to me then, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133