Skip to content
This repository was archived by the owner on Mar 27, 2018. It is now read-only.

[DAQ-474] convert ScanPointsWriter to SolsticeScanMonitor#567

Merged
mpdickie merged 3 commits intomasterfrom
DAQ-474
Feb 24, 2017
Merged

[DAQ-474] convert ScanPointsWriter to SolsticeScanMonitor#567
mpdickie merged 3 commits intomasterfrom
DAQ-474

Conversation

@mpdickie
Copy link
Copy Markdown
Contributor

which now implements IScannable

@mpdickie mpdickie force-pushed the DAQ-474 branch 4 times, most recently from 627ab61 to f5d9fc6 Compare February 23, 2017 16:46
@gerring
Copy link
Copy Markdown
Contributor

gerring commented Feb 24, 2017

SonarQube analysis reported 4 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR SolsticeScanMonitor.java#L137: This block of commented-out lines of code should be removed. rule
  2. MAJOR SolsticeScanMonitor.java#L203: At most one statement is allowed per line, but 2 statements were found on this line. rule
  3. MAJOR SolsticeScanMonitor.java#L241: Define and throw a dedicated exception instead of using a generic one. rule
  4. INFO SolsticeScanMonitor.java#L138: Complete the task associated to this TODO comment. rule

@mpdickie mpdickie merged commit 48f250f into master Feb 24, 2017
@mpdickie mpdickie deleted the DAQ-474 branch February 24, 2017 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants