This repository was archived by the owner on Mar 27, 2018. It is now read-only.
Conversation
gerring
commented
Feb 23, 2017
| // if (gen.containsPoint(x, y)) { | ||
| currentPoint = point; | ||
| index++; | ||
| if (currentPoint!=null) currentPoint.setStepIndex(index); |
Contributor
Author
There was a problem hiding this comment.
At most one statement is allowed per line, but 2 statements were found on this line. 
gerring
commented
Feb 23, 2017
| // position. Therefore we do not need a subscan moderator but can run the iterator | ||
| // to the point | ||
| IPosition pos = positionForStep(stepNumber); | ||
| if (pos == null) throw new ScanningException("Seek position is invalid "+stepNumber); |
Contributor
Author
There was a problem hiding this comment.
At most one statement is allowed per line, but 2 statements were found on this line.
gerring
commented
Feb 23, 2017
| int count=0; | ||
| for (IPosition pos : model.getPositionIterable()) { | ||
| pos.setStepIndex(count); | ||
| if (count == stepNumber) return pos; |
Contributor
Author
There was a problem hiding this comment.
At most one statement is allowed per line, but 2 statements were found on this line.
gerring
commented
Feb 23, 2017
| public boolean hasNext() { | ||
| next = getNext(); | ||
| index++; | ||
| if (next!=null) next.setStepIndex(index); |
Contributor
Author
There was a problem hiding this comment.
At most one statement is allowed per line, but 2 statements were found on this line.
gerring
commented
Feb 23, 2017
|
|
||
| List<IPosition> points = new ArrayList<>(size()); | ||
| createPoints(0, points, null); | ||
| for (int i = 0; i < points.size(); i++) points.get(i).setStepIndex(i); |
Contributor
Author
There was a problem hiding this comment.
At most one statement is allowed per line, but 2 statements were found on this line.
Contributor
Author
|
SonarQube analysis reported 5 issues
Watch the comments in this conversation to review them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.