Conversation
| } | ||
|
|
||
| /** | ||
| * TODO This code is copied from AcquisitionDevice but |
There was a problem hiding this comment.
Complete the task associated to this TODO comment. 
| while(iterator.hasNext()) { | ||
| IPosition pos = iterator.next(); | ||
| pos.setStepIndex(stepNumber); | ||
| if (stepNumber == location) return pos; |
There was a problem hiding this comment.
At most one statement is allowed per line, but 2 statements were found on this line.
| size = ((IPointGenerator<?>)gen).size(); | ||
|
|
||
| } else if (gen!=null) { | ||
| for (IPosition unused : gen) size++; // Fast even for large stuff providing they do not check hardware on the next() call. |
There was a problem hiding this comment.
At most one statement is allowed per line, but 2 statements were found on this line.
Remove this unused "unused" local variable.
| } | ||
| } | ||
|
|
||
| private void positionComplete(IPosition pos) throws EventException, ScanningException { |
There was a problem hiding this comment.
Remove the redundant '!unknownSymbol!' thrown exception declaration(s).
| } | ||
|
|
||
|
|
||
| private int getEstimatedSize(Iterable<IPosition> gen) throws GeneratorException { |
There was a problem hiding this comment.
Remove this unused private "getEstimatedSize" method.
|
SonarQube analysis reported 7 issues
Watch the comments in this conversation to review them. 1 extra issueNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
1 participant
No description provided.