I15_1 (9.3pre) Rewrite MockNeXusSlit to return an NXslit rather than …#575
I15_1 (9.3pre) Rewrite MockNeXusSlit to return an NXslit rather than …#575
Conversation
| * @param container | ||
| * @throws NexusException if the attributes could not be added for any reason | ||
| */ | ||
| private static void registerAttributes(NXobject nexusObject, IScanAttributeContainer container) throws NexusException { |
There was a problem hiding this comment.
Remove this unused private "registerAttributes" method. 
There was a problem hiding this comment.
This is used in the public getNexusProvider() method!
| if (container.getScanAttributeNames()!=null) for(String attrName : container.getScanAttributeNames()) { | ||
| try { | ||
| nexusObject.setField(attrName, container.getScanAttribute(attrName)); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
SonarQube appears to be missing that we now throw without losing the exception, just as in the example.
| } | ||
| } | ||
|
|
||
| private void write(Number demand, Number actual, IPosition loc) throws Exception { |
There was a problem hiding this comment.
Remove this unused private "write" method.
Define and throw a dedicated exception instead of using a generic one.
There was a problem hiding this comment.
write is used in the public setPosition() method!
There was a problem hiding this comment.
Suggestions for which exception to throw appreciated...
| if (demand!=null) { | ||
| int index = loc.getIndex(getName()); | ||
| if (index<0) { | ||
| throw new Exception("Incorrect data index for scan for value of '"+getName()+"'. The index is "+index); |
There was a problem hiding this comment.
Define and throw a dedicated exception instead of using a generic one.
There was a problem hiding this comment.
Suggestions for which exception to throw appreciated...
|
SonarQube analysis reported 4 issues
Watch the comments in this conversation to review them. |
The scannable under test is dcs, which is supposed to be an NXslit, but this test assumes it will be an NXpositioner.
2 participants
…NXpositioner