Conversation
| } | ||
|
|
||
| List<U> items = getSubmissionQueue(); | ||
| if (items!=null && items.size()>0) { |
There was a problem hiding this comment.
Use isEmpty() to check whether the collection is empty or not. 
All devices must have a reasonable timeout set.
| assertEquals(start.getSize(), beans.size()); | ||
| assertEquals(1, startEvents.size()); | ||
|
|
||
| Thread.sleep(100); |
There was a problem hiding this comment.
Remove this use of "Thread.sleep()".
| // Ok done that, now we sent it off... | ||
| submitter.submit(bean); | ||
|
|
||
| Thread.sleep(200); |
There was a problem hiding this comment.
Remove this use of "Thread.sleep()".
| } | ||
|
|
||
|
|
||
| if (!isDurable()) return false; |
There was a problem hiding this comment.
At most one statement is allowed per line, but 2 statements were found on this line.
| // Ok done that, now we sent it off... | ||
| pi.exec("submit("+name+", block="+(blocking?"True":"False")+", broker_uri='"+uri+"')"); | ||
|
|
||
| Thread.sleep(200); |
There was a problem hiding this comment.
Remove this use of "Thread.sleep()".
| // Ok done that, now we sent it off... | ||
| pi.exec("submit("+name+", block="+(blocking?"True":"False")+", broker_uri='"+uri+"')"); | ||
|
|
||
| Thread.sleep(200); |
There was a problem hiding this comment.
Remove this use of "Thread.sleep()".
|
SonarQube analysis reported 8 issues
Watch the comments in this conversation to review them. 2 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
1 participant
Added ability for solstice scanning to automatically pause until the user tells it to run.