Skip to content

Conversation

@gilesknap
Copy link
Contributor

Adds an option to the apptainer type app.

This allows you to list a set of binaries that should be discovered on the host using path and then mounted into the apptainer at /usr/bin.

Also adds:

  • schema annotations for the options fields
  • a test that validates the demo_configuration
  • an example module edge-containers-cli in demo_configuration that demonstrates the use of host_binaries

@gilesknap gilesknap force-pushed the host-binaries branch 3 times, most recently from 1fd92f8 to f5cf111 Compare April 24, 2025 08:02
@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.14%. Comparing base (32ef01f) to head (68e026c).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #25       +/-   ##
===========================================
+ Coverage   42.55%   75.14%   +32.58%     
===========================================
  Files          23       23               
  Lines         860      865        +5     
===========================================
+ Hits          366      650      +284     
+ Misses        494      215      -279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

set -xe

THIS_DIR=$(realpath $(dirname ${0}))
SAMPLES_DIR=${THIS_DIR}/samples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is meant by 'samples'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples is sample output from the sample (demo) definitions. I guess I'm just copying how I did things in ibek here - happy to use a different name but what?

Copy link
Contributor

@MJGaughran MJGaughran Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this type of testing can be called:

  • Snapshot testing
  • Golden Master testing
  • Comparison testing

Since we already use 'snapshot' to refer to something else, perhaps we can use 'comparison_master' instead of 'samples', and put a brief description in the generation script, including the name of the test?

Also rename the test to:
test_compare_demo_configuration_output_to_comparison_master()?

A bit of a mouthful, but at least it's explicit. You could drop 'configuration', too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you reword the VSCode Task description for the comparison_master generation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MJGaughran sorry I missed this one.

Will make another PR at a later date.

@gilesknap
Copy link
Contributor Author

merged with #28

@gilesknap gilesknap closed this Apr 26, 2025
@gilesknap gilesknap deleted the host-binaries branch April 26, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants