Skip to content

Conversation

@MJGaughran
Copy link
Contributor

@MJGaughran MJGaughran commented Jul 3, 2025

This is intended to replace the 'dev mode' status to include separate, dedicated parameters :

  • allow_updates: Allows you to modify all settings of a Module at any time
  • exclude_from_defaults: Excludes the Module from being selected as the default. If all versions of a given Module name are excluded, Validation will fail, to prevent Environment Modules creating its own, implicit default

I have also decided to allow convenience methods on the Pydantic models, as I believe it is clearer than the alternatives. I will make greater use of this as I continue to make other changes to the code.

@MJGaughran MJGaughran requested a review from gilesknap July 3, 2025 21:51
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.35%. Comparing base (2bc13f9) to head (84c8d51).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/deploy_tools/deploy.py 0.00% 3 Missing ⚠️
src/deploy_tools/validate.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   75.63%   76.35%   +0.72%     
==========================================
  Files          24       24              
  Lines         911      901      -10     
==========================================
- Hits          689      688       -1     
+ Misses        222      213       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gilesknap
Copy link
Contributor

Looks good at first glance.
I will try this out against the ec/ixx modules this week.

@gilesknap
Copy link
Contributor

@MJGaughran this is working gud for me and I can now update my ec/xxx modules in place.

I did not try the exclude_from_defaults feature and am not entirely sure what that is for?

@MJGaughran
Copy link
Contributor Author

It's for e.g. alpha and beta releases. If we were to consistently use a particular version scheme we could implicitly ignore them, but exclude_from_defaults makes it explicit

@MJGaughran MJGaughran merged commit 3d8f085 into main Jul 21, 2025
11 checks passed
@MJGaughran MJGaughran deleted the improve-version-management branch November 21, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants