Skip to content

Pin to ophyd-async 0.9.0a1 until save/load compatibility#1015

Merged
rtuck99 merged 1 commit intomainfrom
pin-ophyd-async
Jan 24, 2025
Merged

Pin to ophyd-async 0.9.0a1 until save/load compatibility#1015
rtuck99 merged 1 commit intomainfrom
pin-ophyd-async

Conversation

@DiamondJoseph
Copy link
Contributor

Fixes #1012

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DiamondJoseph DiamondJoseph requested a review from a team as a code owner January 24, 2025 14:14
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (5fe0464) to head (1732997).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         152      152           
  Lines        6351     6351           
=======================================
  Hits         6193     6193           
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callumforrester
Copy link
Contributor

Is there an issue for save/load compatibility?

@DiamondJoseph
Copy link
Contributor Author

Is there an issue for save/load compatibility?

#1017

@rtuck99 rtuck99 merged commit b419318 into main Jan 24, 2025
22 checks passed
@rtuck99 rtuck99 deleted the pin-ophyd-async branch January 24, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update/pin ophyd_async

3 participants