Remove logic for checking if zoom level is available#1018
Merged
DominicOram merged 7 commits intomainfrom Jan 27, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
- Coverage 97.51% 97.50% -0.01%
==========================================
Files 152 152
Lines 6351 6342 -9
==========================================
- Hits 6193 6184 -9
Misses 158 158 ☔ View full report in Codecov by Sentry. |
DominicOram
reviewed
Jan 27, 2025
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
This works but the error message is obtuse (see bluesky/ophyd-async#750). If there is some reason we can't improve the error in ophyd_async then we may want to keep this. I suggest we wait for that issue to have some discussion
DominicOram
approved these changes
Jan 27, 2025
Contributor
There was a problem hiding this comment.
Looks like this will get fixed in ophyd_async (bluesky/ophyd-async#752) so happy to merge this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #884
EPICS enum records should error if provided an unspecified value; thus, this PR removes logic checking for unspecified values in the
ZoomController.Instructions to reviewer on how to test:
strsignallevelto an unspecified zoom level raises an error.Checks for reviewer
dodal connect ${BEAMLINE}