Skip to content

Use gpu results if specified#1025

Merged
DominicOram merged 3 commits intomainfrom
mx_bluesky_771_use_GPU_results
Jan 28, 2025
Merged

Use gpu results if specified#1025
DominicOram merged 3 commits intomainfrom
mx_bluesky_771_use_GPU_results

Conversation

@DominicOram
Copy link
Contributor

Fixes DiamondLightSource/mx-bluesky#771

Instructions to reviewer on how to test:

  1. Confirm behaviour is sensible
  2. Confirm new tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (5c82bbd) to head (fd37791).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   97.52%   97.53%           
=======================================
  Files         154      154           
  Lines        6393     6398    +5     
=======================================
+ Hits         6235     6240    +5     
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olliesilvester olliesilvester self-assigned this Jan 28, 2025
Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one requested change on the mx-bluesky side

@DominicOram
Copy link
Contributor Author

Added a validation check here too so requesting re-review

@DominicOram DominicOram merged commit 388db6a into main Jan 28, 2025
19 checks passed
@DominicOram DominicOram deleted the mx_bluesky_771_use_GPU_results branch January 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle to use GPU results over CPU ones

2 participants