Skip to content

make turbo slit have readable children#1052

Merged
stan-dot merged 3 commits intomainfrom
1051-i20-1-turbo-slit-interfaces---add-children-as-readable
Feb 10, 2025
Merged

make turbo slit have readable children#1052
stan-dot merged 3 commits intomainfrom
1051-i20-1-turbo-slit-interfaces---add-children-as-readable

Conversation

@stan-dot
Copy link
Contributor

Fixes #1051

Instructions to reviewer on how to test:

  1. Do those steps on the device Test out NEXUS file writing i20-1-bluesky#8 (comment)
  2. Confirm correct even documents are sent into the RMQ

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@stan-dot stan-dot added enhancement New feature or request i20-1 labels Feb 10, 2025
@stan-dot stan-dot self-assigned this Feb 10, 2025
@stan-dot stan-dot linked an issue Feb 10, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (b6270c2) to head (9f2031e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         160      160           
  Lines        6599     6600    +1     
=======================================
+ Hits         6446     6447    +1     
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stan-dot and others added 3 commits February 10, 2025 14:02
Co-authored-by: Joseph Ware <53935796+DiamondJoseph@users.noreply.github.com>
Co-authored-by: Joseph Ware <53935796+DiamondJoseph@users.noreply.github.com>
@stan-dot stan-dot force-pushed the 1051-i20-1-turbo-slit-interfaces---add-children-as-readable branch from 223bda2 to 9f2031e Compare February 10, 2025 14:02
@stan-dot stan-dot marked this pull request as ready for review February 10, 2025 14:05
@stan-dot stan-dot requested a review from a team as a code owner February 10, 2025 14:05
@stan-dot stan-dot merged commit 65edfe2 into main Feb 10, 2025
19 checks passed
@stan-dot stan-dot deleted the 1051-i20-1-turbo-slit-interfaces---add-children-as-readable branch February 10, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request i20-1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i20-1 turbo slit interfaces - add children as readable

2 participants