Skip to content

Update bluesky and pin pyright#1072

Merged
olliesilvester merged 6 commits intomainfrom
1041_update_bluesky
Feb 28, 2025
Merged

Update bluesky and pin pyright#1072
olliesilvester merged 6 commits intomainfrom
1041_update_bluesky

Conversation

@DominicOram
Copy link
Contributor

Fixes #1041

Instructions to reviewer on how to test:

  1. Run unit tests and confirm they still pass
  2. Confirm new type hints look correct
  3. Confirm no new typing errors

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (5893821) to head (e7d1dbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         160      160           
  Lines        6635     6638    +3     
=======================================
+ Hits         6482     6485    +3     
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram
Copy link
Contributor Author

DominicOram commented Feb 27, 2025

Latest pyright is also more fussy, I will pin that in this PR too and improve in #1079

@DominicOram DominicOram changed the title Update bluesky Update bluesky and pin pyright Feb 27, 2025
Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Question about the wrapped functions but we can put that in a separate issue


# After bluesky 1.14, bounds for stubs that move can be narrowed
# https://github.com/bluesky/bluesky/issues/1821
def set_absolute(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be another issue, but maybe we can remove a bunch of these now that typing has improved? @DiamondJoseph are these wrappers still useful?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh the bluesky type hinting went in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These wrapped stubs are still required for blueapi because the bluesky version plan stubs aren't serializable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So they are going to be needed permanently? Can we make the comment clearer then? Currently it reads:

"""
Wrappers for Bluesky built-in plan stubs with type hinting
"""

Which is confusing given we already have types here

@olliesilvester olliesilvester merged commit a3b1b8c into main Feb 28, 2025
19 checks passed
@olliesilvester olliesilvester deleted the 1041_update_bluesky branch February 28, 2025 10:37
DominicOram added a commit that referenced this pull request Mar 3, 2025
DominicOram added a commit that referenced this pull request Mar 3, 2025
* Revert "Update bluesky and pin pyright (#1072)"

This reverts commit a3b1b8c.

* Pin pyright version

* Actually pin the version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bluesky version

3 participants