Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
=======================================
Coverage 97.69% 97.69%
=======================================
Files 160 160
Lines 6635 6638 +3
=======================================
+ Hits 6482 6485 +3
Misses 153 153 ☔ View full report in Codecov by Sentry. |
|
Latest |
|
|
||
| # After bluesky 1.14, bounds for stubs that move can be narrowed | ||
| # https://github.com/bluesky/bluesky/issues/1821 | ||
| def set_absolute( |
There was a problem hiding this comment.
This can be another issue, but maybe we can remove a bunch of these now that typing has improved? @DiamondJoseph are these wrappers still useful?
There was a problem hiding this comment.
Oooh the bluesky type hinting went in
There was a problem hiding this comment.
These wrapped stubs are still required for blueapi because the bluesky version plan stubs aren't serializable.
There was a problem hiding this comment.
So they are going to be needed permanently? Can we make the comment clearer then? Currently it reads:
"""
Wrappers for Bluesky built-in plan stubs with type hinting
"""Which is confusing given we already have types here
This reverts commit a3b1b8c.
Fixes #1041
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}