Skip to content

Add i19 optics beamline definition#1091

Merged
noemifrisina merged 3 commits intomainfrom
1090_i19-optics-definition
Mar 10, 2025
Merged

Add i19 optics beamline definition#1091
noemifrisina merged 3 commits intomainfrom
1090_i19-optics-definition

Conversation

@noemifrisina
Copy link
Collaborator

Fixes #1090
See also i19-bluesky#33

Instructions to reviewer on how to test:

1.Run dodal connect i19-optics and verify it connects

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@noemifrisina noemifrisina requested a review from a team as a code owner March 4, 2025 17:51
@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (6e0fd7b) to head (9215b16).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         160      161    +1     
  Lines        6638     6650   +12     
=======================================
+ Hits         6485     6497   +12     
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@noemifrisina noemifrisina merged commit a1a6d41 into main Mar 10, 2025
19 checks passed
@noemifrisina noemifrisina deleted the 1090_i19-optics-definition branch March 10, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create i19_optics beamline definition

2 participants