Skip to content

(mx-bluesky#289) Add units to exposure_time parameter name#1102

Merged
JamesDoingStuff merged 1 commit intomainfrom
mx_bluesky_289_exposure_time_units
Mar 11, 2025
Merged

(mx-bluesky#289) Add units to exposure_time parameter name#1102
JamesDoingStuff merged 1 commit intomainfrom
mx_bluesky_289_exposure_time_units

Conversation

@JamesDoingStuff
Copy link
Contributor

Fixes mx-bluesky#289

Instructions to reviewer on how to test:

  1. Search repo for exposure_time variable
  2. Ensure there are no occurrences that aren't renamed to exposure_time_s

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@JamesDoingStuff JamesDoingStuff requested a review from a team as a code owner March 11, 2025 10:15
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (fcfe95f) to head (71a5686).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         161      161           
  Lines        6652     6652           
=======================================
  Hits         6499     6499           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, anyone other than mx-bluesky who use DetectorParams will need to update too, although it might just be MX who use it

@DiamondJoseph
Copy link
Contributor

it might just be MX who use it

I believe this is the case

@JamesDoingStuff JamesDoingStuff merged commit 94519bf into main Mar 11, 2025
22 checks passed
@JamesDoingStuff JamesDoingStuff deleted the mx_bluesky_289_exposure_time_units branch March 11, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exposure time parameter should have units

3 participants