Skip to content

Fix new ruff linting#1118

Merged
DominicOram merged 2 commits intomainfrom
1117_fix_for_latest_ruff_version
Mar 14, 2025
Merged

Fix new ruff linting#1118
DominicOram merged 2 commits intomainfrom
1117_fix_for_latest_ruff_version

Conversation

@DominicOram
Copy link
Contributor

Fixes #1117

Instructions to reviewer on how to test:

  1. Install the latest ruff version (pip install --upgrade ruff)
  2. On main run ruff check, confirm there are errors
  3. On this branch run ruff check and confirm no errors

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram requested a review from a team as a code owner March 14, 2025 09:42
@DominicOram DominicOram mentioned this pull request Mar 14, 2025
4 tasks
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (50d6766) to head (e1f2ee8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1118   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         164      164           
  Lines        6690     6690           
=======================================
  Hits         6537     6537           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DominicOram DominicOram merged commit b3cc4d0 into main Mar 14, 2025
19 checks passed
@DominicOram DominicOram deleted the 1117_fix_for_latest_ruff_version branch March 14, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New ruff version issues with c420

2 participants