Add roistat plugin to ViSR spectroscopy detector#1390
Conversation
dc00b44 to
c3cbe40
Compare
| @@ -1,4 +1,5 @@ | |||
| from ophyd_async.epics.adaravis import AravisDetector | |||
| from ophyd_async.epics.adcore import NDROIStatIO | |||
| from ophyd_async.fastcs.panda import HDFPanda | |||
There was a problem hiding this comment.
Since this adds a dependency on a new device to dodal, you should bump the ophyd-async dependency version in pyproject.toml
rtuck99
left a comment
There was a problem hiding this comment.
Approved, however I note that if I try to do dodal connect b01_1 on a b01-1-ws001 I get PATH_PROVIDER is not defined, so I assume there is some additional setup required?
Ideally it would be good if dodal connect works without modificatons, other beamlines set a default in the beamline module.
|
@rtuck99 This may have been an error on my part or it may require #1129, I will investigate. Edit: It would seem, and I did not realise this, that b01-1 is the first beamline we've got fully using numtracker, so we're encountering all the teething problems. Blueapi's numtracker client refuses to work with anything but it's own path provider, #1129 is an issue for resolving this, so I will see if I can push it forward. |
c3cbe40 to
10e09d2
Compare
|
Updated on main, which has bumped the ophyd-async dependency, so I think this is good to merge now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 232 232
Lines 8592 8594 +2
=======================================
+ Hits 8483 8485 +2
Misses 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}